Details
-
Suggestion
-
Resolution: Done
-
P4: Low
-
4.4.1
-
None
-
ac00b5155eb3fc449d7a845508f1114e0c78d89e (qt/qtbase/wip/qt6)
Description
The addKey method currently encloses the "+" sign with a tr call, but no comment.
static inline void addKey(QString &str, const QString &theKey, QKeySequence::SequenceFormat format) { if (!str.isEmpty()) str += (format == QKeySequence::NativeText) ? QShortcut::tr("+") : QString::fromLatin1("+"); str += theKey; }
It would be nice if there was context information added, like the following:
QShortcut::tr("+", "Key separator in shortcut string")
Attachments
For Gerrit Dashboard: QTBUG-2657 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
142799,1 | Add comment to a tr() call | 5.6 | qt/qtbase | Status: ABANDONED | 0 | 0 |
250711,3 | Add comment to a tr() call | dev | qt/qtbase | Status: MERGED | +2 | 0 |