Details
-
Bug
-
Resolution: Done
-
P4: Low
-
5.4.0
-
None
-
307f55129181f67fb99bd9dd38b7017928a0aae1 (qtbase/dev, 16.6.2015, 5.6)
Description
Code in QMapData::deleteNode() triggers warning C4127: conditional expression is constant. qmap.h already suppresses this warning for QMapNode::destroySubTree() just before QMapData::deleteNode(), #pragma warning(pop) just needs to be moved one function down.
destroySubTree() triggers warning 4718 when QMap is used with simple types, like QMap<int, Foo*>:
warning C4718: 'QMapNode<int,MooEdit * __ptr64>::destroySubTree' : recursive call has no side effects, deleting
Attachments
Issue Links
- is duplicated by
-
QTBUG-31516 Windows, MSVC2010+: Warning C4718 with QMap when using /W 4
- Closed
- replaces
-
QTBUG-54089 MSVC warnings 4718 in QMapData
- Closed