Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-51938

ANGLE build uses -march=native

    XMLWordPrintable

Details

    • 6a85b950a4af63c8f5213bd04d5e779213edfe81 in 5.6, e12ba07322cd61c5cf50c25ed8d1f08f6b1ff879 in 5.7

    Description

      src/angle/src/config.pri
      gcc {
          QMAKE_CFLAGS_WARN_ON += -Wno-unknown-pragmas -Wno-comment -Wno-missing-field-initializers \
                                  -Wno-switch -Wno-unused-parameter -Wno-write-strings -Wno-sign-compare -Wno-missing-braces \
                                  -Wno-unused-but-set-variable -Wno-unused-variable -Wno-narrowing -Wno-maybe-uninitialized \
                                  -Wno-strict-aliasing -Wno-type-limits -Wno-unused-local-typedefs
      
          QMAKE_CXXFLAGS_WARN_ON = $$QMAKE_CFLAGS_WARN_ON -Wno-reorder -Wno-conversion-null -Wno-delete-non-virtual-dtor
      
          sse2: QMAKE_CXXFLAGS += -march=native
      }
      

      That -march=native is incorrect and it causes GCC to generate code that cannot be sent to another machine. Since sse2 is enabled for all x86-64 builds, as a consequence this makes the ANGLE libraries not portable at all.

      That line was added with commit a6a12d8c0fc918972c15268f749ecc7c90b95d6c (ANGLE: upgrade to 2.1~07d49ef5350a) and it must go.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            owolff Oliver Wolff
            thiago Thiago Macieira
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes