Details
-
Bug
-
Resolution: Done
-
P3: Somewhat important
-
5.7.1, 5.8.0 RC
-
None
-
Windows, MSVC 2015 compiler
-
bd4506fe5be0616c1d1f4cac94bb7399dc2072c2
Description
Every single occurrence of toUpper() and toLower() methods (probably also trimmed(), and that may not be a complete list still) trigger the C4714 warning in MSVC 2015.
This issue had been reported before and closed: https://bugreports.qt.io/browse/QTBUG-55042
The reasoning given for closing that issue is just not sensible and the two other commenters have a point. Since I can't vote to reopen the issue I'm forced to create a new one.
The C4714 warning is justified: if you mark something __forceinline, you probably have a reason. You must need it really bad. When you need something really bad and that doesn't happen, you want to know about that. What's not justified is marking these __forceinline in the first place.
Moreover, this wouldn't be much of a problem if the error was placed in the Qt headers. I already have to wrap every single #include <QSomething> with #pragma warning (push, 0) because some headers produce a huge number of warnings. But C4714 occurs at the site of method call, not declaration (which also makes sense), and no, I won't be disabling this warning for my project globally.
Attachments
Issue Links
- relates to
-
QTBUG-55042 QString toUpper and toLower functions can not be force inlined
- Closed