Details
-
Bug
-
Resolution: Done
-
P2: Important
-
5.9.0 Beta 2
-
None
-
121d88ee663ab3dffdcbc207135137c3fb0c8ef9
Description
In 'src/plugins/directshow/player/directshowmetadatacontrol.cpp', it has code similar to:
void f()
{
goto send_event;
void *p = nullptr;
if (p) {
}
send_event: ;
}
This is ill-formed because 'goto' skips the initialization of 'p'.
One possible fix is to change:
IWMHeaderInfo *info = com_cast<IWMHeaderInfo>(source, IID_IWMHeaderInfo);
if (info) {
to
if (IWMHeaderInfo *info = com_cast<IWMHeaderInfo>(source, IID_IWMHeaderInfo);) {
Attachments
| For Gerrit Dashboard: QTBUG-60464 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 196872,3 | Fix goto bypassing variable initialization | 5.9 | qt/qtmultimedia | Status: MERGED | +2 | 0 |