Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-64275

Inconsistent use of QT_CONFIG(opensslv11)

    XMLWordPrintable

Details

    • Suggestion
    • Resolution: Done
    • P4: Low
    • 5.11.0
    • 5.10.0 Beta 3, 5.10
    • Network: SSL
    • None

    • gentoo linux x86_64.  All unix based platorms affected.

    • 16b76456be8d00ca70715286906b7c482a158dc4

    Description

      Qt 5.10 performs a configure test to determine if the openssl version is 1.1 or greater.  The code then uses

      #if QT_CONFIG(opensslv11)

      to test for this.

       

      However, there are 3 places in the code where

      #if OPENSSL_VERSION_NUMBER >= 0x10100000L

      is used instead.  Two are in src/network/ssl/qsslsocket_openssl_symbols_p.h and one is in src/network/ssl/qsslsocket_openssl_symbols.cpp.  These three should be converted to the QT_CONFIG style for consistency.

       

      Patch attached.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            tpochep Timur Pocheptsov
            maurerpe maurerpe
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes