Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-75214

Certain ICO files display with significant artifacts after loading

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P2: Important
    • 5.12.4, 5.14.0 Alpha
    • 5.12.0, 5.12.1
    • Image formats
    • None
    • All
    • 1d128ed1dfbcf49453ada922e54381c37264fde5 (qt/qtbase/5.12)

    Description

      In debugging the favorite icon download feature for KeePassXC I came upon several websites that have their favicon files showing as corrupt in our application. I thought it was something we were doing when handling network data, but it also occurs when loading the same ico from disk. I then thought it was a problem with QImage::scale or the conversion from QImage to QPixmap for display in the GUI, however I have ruled out both of those cases as well. This leaves me to believe the error is occurring directly in the ICO Image Format plugin. This does not occur with all ICO's but I have two samples from Delta and LinkedIn that show significant artifacts.

       

      Our icon handling code is found here if you want to review it: https://github.com/keepassxreboot/keepassxc/blob/04983ce4cd3ca3e835e05b627907859ac97db5d3/src/gui/EditWidgetIcons.cpp#L378-L406

      Attachments

        1. corrupt_ico_in_gui.png
          corrupt_ico_in_gui.png
          28 kB
        2. delta.com.ico
          23 kB
        3. linkedin.com.ico
          32 kB
        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            vgt Eirik Aavitsland
            droidmonkey Jonathan White
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes