Uploaded image for project: 'Qt for Python'
  1. Qt for Python
  2. PYSIDE-839

If statement without code block

    XMLWordPrintable

Details

    • Bug
    • Resolution: Invalid
    • Not Evaluated
    • None
    • 5.11.2
    • PySide
    • None

    Description

      https://code.qt.io/cgit/pyside/pyside-setup.git/tree/sources/pyside2/libpyside/globalreceiverv2.cpp

      Lines 271-274: 

          if (m_refs.empty())
              Py_BEGIN_ALLOW_THREADS
              delete this;
              Py_END_ALLOW_THREADS
      

      Either this is a bug and all 3 lines should be within a code block, or the indentation on the last two lines is wrong. Considering in PySide(1) the code is the same but without the Py_BEGIN/END_ALLOW_THREADS, I'm guessing it's the former.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            crmaurei Cristian Maureira-Fredes
            rguessford raymond guessford
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes