Loading...

XML

Word

Printable

Platform/s:

All
Story Points:
5
Commits:
d11941db41 (qt/qtbase/dev) cd7eb2f429 (qt/qtbase/6.3) c097807ebf (qt/qtbase/6.2) c097807ebf (qt/tqtc-qtbase/6.2) cd7eb2f429 (qt/tqtc-qtbase/6.3) d11941db41 (qt/tqtc-qtbase/dev)
Sprint:
Team A Foundation Sprint 55

This code loops infinitely or crashs:

QHash<int, int> test;
for (int i = 0; i < 1000; ++i)
    test.insert(i, i);
test.reserve(1);

Found in my real life project

I assume the trivial fix would be to internally just use the max of the current size and the passed value.

For Gerrit Dashboard: QTBUG-102067
#	Subject	Branch	Project	Status	CR	V
403416,4	Q[Multi]Hash::reserve(): do nothing if desired size is less than current	dev	qt/qtbase	Status: MERGED	+2	0
404929,2	Q[Multi]Hash::reserve(): do nothing if desired size is less than current	6.2	qt/qtbase	Status: MERGED	+2	0
404930,2	Q[Multi]Hash::reserve(): do nothing if desired size is less than current	6.3	qt/qtbase	Status: MERGED	+2	0