Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-141487

Insufficient handling of errors and corner cases in parsePathDataFast()

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: P3: Somewhat important P3: Somewhat important
    • None
    • 6.11
    • SVG Support
    • None

      parsePathDataFast() does not write any warnings. It can indicate errors to the caller only by returning a std::nullopt to which the caller can then react by writing a warning. This is not exact enough to handle the various possible cases:

      • When the function returns std::nullopt, no warning should be written if dataStr is empty or "none".
      • When the function returns an actual QPainterPath, it should still issue a warning if the contents of dataStr were partially invalid.

      It seems like parsePathDataFast() itself - and not the caller - should decide on when to log a warning.

        For Gerrit Dashboard: QTBUG-141487
        # Subject Branch Project Status CR V

            rlohning Robert Löhning
            rlohning Robert Löhning
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                There is 1 open Gerrit change