Details
-
Bug
-
Resolution: Done
-
P3: Somewhat important
-
5.8.0
-
None
-
c071b588ce2b4d474845d553aa83120747dc46da
Description
These classes declare a few methods as virtual while there doesn't seem to be any reason for the methods to be virtual:
- QAbstractOAuth::clientIdentifier: just return whatever has been set with setClientIdentifier()
- QAbstractOAuth::setClientIdentifier: just store the string in the private structure
- QAbstractOAuth::token and QAbstractOAuth::token: same as above
- QAbstractOAuth2::responseType: add a (protected?) setResponseType() method and just return the value set with that method.
Attachments
For Gerrit Dashboard: QTBUG-60809 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
194820,8 | Move some functions to base classes to avoid virtual | dev | qt/qtnetworkauth | Status: MERGED | +2 | 0 |