Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-60809

QAbstractOAuth{,2} use virtual methods for no good reason

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P3: Somewhat important
    • Resolution: Done
    • Affects Version/s: 5.8.0
    • Fix Version/s: 5.10.0 Alpha
    • Labels:
      None
    • Commits:
      c071b588ce2b4d474845d553aa83120747dc46da

      Description

      These classes declare a few methods as virtual while there doesn't seem to be any reason for the methods to be virtual:

      • QAbstractOAuth::clientIdentifier: just return whatever has been set with setClientIdentifier()
      • QAbstractOAuth::setClientIdentifier: just store the string in the private structure
      • QAbstractOAuth::token and QAbstractOAuth::token: same as above
      • QAbstractOAuth2::responseType: add a (protected?) setResponseType() method and just return the value set with that method.

       

        Attachments

        For Gerrit Dashboard: QTBUG-60809
        # Subject Branch Project Status CR V

          Activity

            People

            • Assignee:
              jefernan Jesus Fernandez
              Reporter:
              mardy Alberto Mardegan
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Gerrit Reviews

                There are no open Gerrit changes