Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-68939

Regression caused by the fix for QTBUG-16252

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P1: Critical
    • 5.9.7
    • 5.9.6
    • Widgets: Widgets and Dialogs
    • None
    • Should be platform agnostic.
    • eaa2e164b0559b37dbcd060cd31e110d2775ffd6

    Description

      The fix for QTBUG-16252 introduced a regression which I have so far only seen in KDevelop.

       

      There, document views behave as if hidden dock widgets are in fact expanded, with the result that they are too narrow and not high enough. Expanding a dock widget (on any edge) and changing its width or height (or changing the width/height of an already expanded dock widget) restores the proper doc view dimensions. This fix persists when the dock widget is hidden again (= the doc view takes up all available space) but not when I change to another doc view (in KDevelop's tabbed interface).

       

      Resizing the entire window doesn't help; doc views and the unoccupied space are resized proportionally.

       

      This issue disappears when I revert commit #cbfb6bda1d1ce3e169db6a0deb9bd901076653e4 .

      Attachments

        1. docks.png
          docks.png
          122 kB
        2. dolphin-18.04.2_with_qt-5.9.6.png
          dolphin-18.04.2_with_qt-5.9.6.png
          60 kB
        3. QMainWindowX.cpp
          3 kB
        4. QMainWindowX.h
          1.0 kB
        5. qt596-qtbug16252-regression-glitch.png
          qt596-qtbug16252-regression-glitch.png
          49 kB

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-69297 QDockWidget: Empty space appears after using restoreState

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTCREATORBUG-20767 Qt Creator defect of view

          • Not Evaluated - Not yet evaluated/prioritized
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-69297 QDockWidget: Empty space appears after using restoreState

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          resulted from

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-16252 QDockWidgets of maximized windows are not restored to the correct size when calling QWidget::restoreGeometry() , QMainWindow::restoreState() in a sequence

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          For Gerrit Dashboard: QTBUG-68939
          # Subject Branch Project Status CR V
          236718,1 Fix restoring geometry of dockwidget 5.11 qt/qtbase Status: NEW -1 0
          233482,6 Revert "Fix restoring geometry of dockwidget" 5.9 qt/qtbase Status: MERGED +2 0

          Activity

            People

              qt.team.quick.subscriptions Qt Quick and Widgets Team
              rjvbertin René Bertin
              Votes:
              12 Vote for this issue
              Watchers:
              20 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There is 1 open Gerrit change