Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-70968

AGLFN is under BSD license, but the license is not being attributed

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P1: Critical
    • Resolution: Done
    • Affects Version/s: 5.11.2
    • Fix Version/s: 5.12.5
    • Component/s: GUI: Text handling
    • Labels:
      None
    • Commits:
      a3dec41cf1c8078e11eae90167a0282eba2ce084

      Description

      In qtbase, src/gui/text/qfontsubset_agl.cpp is generated by util/aglfn/main.cpp (and a copy of the AGLFN). This is all fine, except that the AGLFN is under a BSD license, and that license is not reflected in qfontsubset_agl.cpp (and license attribution is a requirement of BSD). You can see the licensing of the AGLFN here: https://github.com/adobe-type-tools/agl-aglfn

      The quick fix is to change the header value in util/aglfn/main.cpp to include something like:

      ** This file contains material derived from the Adobe Glyph List For New Fonts, ** which is licensed under the BSD license:
      ** Copyright 2002, 2003, 2005, 2006, 2008, 2010, 2015 Adobe Systems 
      ** Incorporated. All rights reserved.
      **
      ** Redistribution and use in source and binary forms, with or without
      ** modification, are permitted provided that the following conditions are met:
      **
      ** Redistributions of source code must retain the above copyright notice, this ** list of conditions and the following disclaimer.
      **
      ** Redistributions in binary form must reproduce the above copyright notice, 
      ** this list of conditions and the following disclaimer in the documentation 
      ** and/or other materials provided with the distribution.
      **
      ** Neither the name of Adobe Systems Incorporated nor the names of its 
      ** contributors may be used to endorse or promote products derived from this 
      ** software without specific prior written permission.
      **
      ** THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" ** AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
      ** IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ** ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
      ** LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR 
      ** CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF 
      ** SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS 
      ** INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN 
      ** CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) 
      ** ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE 
      ** POSSIBILITY OF SUCH DAMAGE.
      

       

      You probably also want to include a copy of their BSD license in any qt binary distribution that you may do. Adding it as a LICENSE.AGLFN-BSD (or something similar) helps downstreams be in compliance.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            • Assignee:
              esabraha Eskil Abrahamsen Blomfeldt
              Reporter:
              spotrh Tom Callaway
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Gerrit Reviews

                There are no open Gerrit changes