Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-77867

After network disconnection/connection, in progress HTTP requests retry with wrong range.

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P2: Important
    • 5.12
    • 5.12.5, 5.13.0
    • Network
    • None
    • Windows
    • 02a62094876c51b71f5922d168305ffc970f24c6

    Description

      We are trying to download a remote file from a start offset to the end of file using this HTTP range request:

      bytes=9500-

      When we unplug the network cable, and then reconnect it after some seconds, another Get request is sent by Qt to resume download, However the new range request end offset is wrong, because Qt assumes that there is always an end offset for the HTTP range request. 

      https://github.com/qt/qtbase/blob/53d62b8fcbb639bd625777c8f1c01764445fb1c4/src/network/access/qnetworkreplyhttpimpl.cpp#L753

      so it sends this request that is wrong:

      bytes=9500-0

      We added the end offset to the request and the issue is fixed but in some situations we do not know the total downloading file size.
      Also the RFC of ranged request states that the end offset is optional.

       

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            tpochep Timur Pocheptsov
            hojjatjafary Hojjat Jafary
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes