Details
P1: Critical Description
After https://codereview.qt-project.org/c/qt/qtbase/+/299983 , Port qt_urlRecode() to QStringView
some code in qtwebsockets got break. code example like:
bool m_isValid; QString host = QStringLiteral(":def@foo.com"); // or QStringLiteral("@foo.com") QUrl m_requestUrl; m_requestUrl.setAuthority(host); if (!m_requestUrl.userName().isNull()) { m_isValid = false; // it's true now after the qtbase change }
More details:
Attachments
| For Gerrit Dashboard: QTBUG-84315 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 301150,2 | Blacklist two tests in handshakerequest | dev | qt/qtwebsockets | Status: MERGED | +2 | 0 |
| 453714,3 | QUrl: restore empty-but-not-null for components that are present | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 454765,2 | QUrl: restore empty-but-not-null for components that are present | 6.5 | qt/qtbase | Status: MERGED | +2 | 0 |
| 454799,2 | QUrl: restore empty-but-not-null for components that are present | tqtc/lts-6.2 | qt/tqtc-qtbase | Status: MERGED | +2 | 0 |
| 454887,4 | Revert "Blacklist two tests in handshakerequest" | dev | qt/qtwebsockets | Status: MERGED | -1 | 0 |
| 455424,2 | Revert "Blacklist two tests in handshakerequest" | 6.4 | qt/qtwebsockets | Status: MERGED | +2 | 0 |
| 455425,2 | Revert "Blacklist two tests in handshakerequest" | 6.5 | qt/qtwebsockets | Status: MERGED | +2 | 0 |
| 455435,2 | Revert "Blacklist two tests in handshakerequest" | tqtc/lts-6.2 | qt/tqtc-qtwebsockets | Status: MERGED | +2 | 0 |
| 456239,2 | QUrl: restore empty-but-not-null for components that are present | 6.4 | qt/qtbase | Status: MERGED | +2 | 0 |