Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-90961

Recent tidy-up broke builds with system double-conversion library

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P1: Critical
    • Resolution: Done
    • Affects Version/s: 6.2
    • Fix Version/s: 6.2
    • Labels:
      None
    • Commits:
      5bd16f132dcc4d16d7ba7e91ffba92ff005b91e4 (qt/qtbase/dev)

      Description

      A recent clean-up of our double-conversion third-party code breaks building with system double-conversion libraries, which presume a #include <double-conversion/double-conversion.h> where the linked change removes the directory-layer from that path.
      The upstream sources use #include "name.h" with no path component for their mutual inclusions, so building them requires an include path that has their directory in it; but for our code to include the export header as above, we need to give the compiler an include path with the last path-component omitted, so that the source can supply that last component.
      Hopefully CMake can support using different include paths for different source files.

        Attachments

        For Gerrit Dashboard: QTBUG-90961
        # Subject Branch Project Status CR V

          Activity

            People

            Assignee:
            Eddy Edward Welbourne
            Reporter:
            Eddy Edward Welbourne
            PM Owner:
            Maurice Kalinowski Maurice Kalinowski
            RnD Owner:
            Alex Blasche Alex Blasche
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes