Details
-
Task
-
Resolution: Done
-
Not Evaluated
-
None
-
None
-
None
Description
There are several problems with this property:
- It's not used anywhere, except for dev/apps/com.pelagicore.sheets/components/ButtonPanel.qml
- Such a case should be handled by changing the appropriate property in the NeptuneStyle attached property for the button in question instead of creating a new property wich overlaps existing API (NeptuneStyle). That's one of the use cases intended to be solved by having a style being an attached property instead of a singleton. Let's use it!
- It's a bad name. It you think about it, every property is "custom" the moment you set a value different from the default one. So in that sense we should prefix every property with "custom"
- There's "magic" going on there. Setting a customBackgroundColor not only changes the background color but also the opacity of the background. So this property is exceeding is contract and having undisclosed side effects. If you need to change the opacity behavior, it should be done explicitly.