Uploaded image for project: 'Qt for Python'
  1. Qt for Python
  2. PYSIDE-2155

Support cmake UNITY_BUILD

    XMLWordPrintable

Details

    • Suggestion
    • Resolution: Fixed
    • Not Evaluated
    • 6.5.0
    • 6.x
    • Build System
    • None
    • All
    • 2e7fea616 (dev), 83f7993e9 (dev), e35ade028 (dev), b6d8b5f77 (dev), 68db55978 (dev), 7786dbfad (dev), fc40a3b5c (dev), 7b716e2c4 (dev), d082c3cbe (dev), 8d2d8f9c5 (dev), 2a37c2a1c (dev), 7c670b40b (dev), 5ef2f78f7 (dev), ae4131593 (dev), 6ada63dab (dev)

    Description

      pyside is a quite large project ant takes time to build

      it could be great to support cmake unity/jumbo build and greatly reduce build time:

      https://cmake.org/cmake/help/latest/prop_tgt/UNITY_BUILD.html

      I tried passing "cmake -DCMAKE_UNITY_BUILD=ON -DCMAKE_UNITY_BUILD_BATCH_SIZE=16"

      typical errors are static variables cloberring and ambiguous namespaces

      I tried to fix a few of these but did not succeed to get very far (see attached patch)

       

       

       

      Attachments

        1. unity.patch
          5 kB
        2. unity-1.patch
          10 kB
        3. unity-2.patch
          9 kB
        4. unity-3.patch
          15 kB

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. PYSIDE-500 Fix Inheritance of PySide (Windows build broken)

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. QTBUG-109394 Support cmake UNITY_BUILD

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed
          For Gerrit Dashboard: PYSIDE-2155
          # Subject Branch Project Status CR V
          512264,4 WIP: QtWidgets: Move the layout helper code to separate glue files dev pyside/pyside-setup Status: NEW -2 0
          448668,3 WIP: Use CMake UNITY_BUILD (jumbo) for modules dev pyside/pyside-setup Status: ABANDONED -2 0
          448695,2 shiboken6: Fix the multiple inheritance code generation for CMake UNITY_BUILD (jumbo) dev pyside/pyside-setup Status: MERGED +2 0
          448696,2 shiboken6: Fix the smartpointer code generation for CMake UNITY_BUILD (jumbo) dev pyside/pyside-setup Status: MERGED +2 0
          448697,7 PySide6: Fix CMake UNITY_BUILD (jumbo) builds for modules dev pyside/pyside-setup Status: MERGED +2 0
          449041,6 PySide6: Expand template PyDateTime_ImportAndCheck dev pyside/pyside-setup Status: MERGED +2 0
          449043,6 libpyside: Rename the static strings dev pyside/pyside-setup Status: MERGED +2 0
          449044,6 PySide6: Fix CMake UNITY_BUILD (jumbo) builds of the libraries dev pyside/pyside-setup Status: MERGED +2 0
          449045,6 Fix redefinition of type name PySideQFlagsTypePrivate dev pyside/pyside-setup Status: MERGED +2 0
          449046,6 libpyside: Rename namespace PySide::QFlags dev pyside/pyside-setup Status: MERGED +2 0
          449047,13 Build system: Add an option to enable CMake UNITY_BUILD (jumbo) builds dev pyside/pyside-setup Status: MERGED +2 0
          449048,12 COIN: Use --unity builds dev pyside/pyside-setup Status: MERGED +2 0
          449152,12 shiboken6/test: Remove using namespace std dev pyside/pyside-setup Status: MERGED +2 0
          449253,4 shiboken6/test: Rename typedef HANDLE in libsample dev pyside/pyside-setup Status: MERGED +2 0
          449353,2 PySide6: Remove include module-local include "core_snippets_p.h" from headers dev pyside/pyside-setup Status: MERGED +2 0
          449354,9 shiboken6: Include base class wrapper headers of the current module when avoiding the protected hack dev pyside/pyside-setup Status: MERGED +2 0
          449542,2 PySide6: Add missing include for QWidget dev pyside/pyside-setup Status: MERGED +2 0
          449574,3 Clean up include statements dev pyside/pyside-setup Status: MERGED +2 0
          449623,2 Fix unity build of QtDataVisualization dev pyside/pyside-setup Status: MERGED +2 0
          449733,2 Documentation: Mention Unity build mode dev pyside/pyside-setup Status: MERGED +2 0
          449853,5 shiboken6: Refactor code for generating wrapper headers dev pyside/pyside-setup Status: MERGED +2 0
          449867,4 libshiboken: Include windows.h with consistent defines dev pyside/pyside-setup Status: MERGED +2 0
          488066,2 shiboken6: Generate the protected hack define into all files dev pyside/pyside-setup Status: MERGED +2 0
          488103,2 shiboken6: Generate the protected hack define into all files 6.5 pyside/pyside-setup Status: MERGED +2 0
          511756,2 Fix Unity build of QtGui dev pyside/pyside-setup Status: MERGED +2 0
          511823,2 Fix Unity build of QtGui 6.6 pyside/pyside-setup Status: MERGED +2 0
          511826,2 Fix Unity build of QtGui 6.5 pyside/pyside-setup Status: MERGED +2 0
          512566,2 Fix Unity build of QtQuick dev pyside/pyside-setup Status: MERGED +2 0
          512622,2 Fix Unity build of QtQuick 6.6 pyside/pyside-setup Status: MERGED +2 0
          512710,2 Fix Unity build of QtQuick 6.5 pyside/pyside-setup Status: MERGED +2 0
          528384,2 QtGui: Fix a unity build error related to QShaderVersion (QRhi) dev pyside/pyside-setup Status: MERGED +2 0
          528492,2 QtGui: Fix a unity build error related to QShaderVersion (QRhi) 6.6 pyside/pyside-setup Status: MERGED +2 0

          Activity

            People

              crmaurei Cristian Maureira-Fredes
              jschueller Julien Schueller
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There is 1 open Gerrit change