Uploaded image for project: 'Qt for Python'
  1. Qt for Python
  2. PYSIDE-565

pyside-tools installs man pages on windows

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P4: Low
    • None
    • 5.6, 5.9
    • PySide
    • None

    Description

      It's just a typo in the cmake logic:

      diff --git a/CMakeLists.txt b/CMakeLists.txt
      index af33d0f..a077459 100644
      --- a/CMakeLists.txt
      +++ b/CMakeLists.txt
      @@ -53,7 +53,7 @@ install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/pyside2uic
               PATTERN "*pyside2uic\\__init__.py" EXCLUDE)
       
       # Man pages for pyside2-uic
      -if (NOT win32)
      +if (NOT WIN32)
           file(GLOB manpages "${CMAKE_CURRENT_SOURCE_DIR}/pyside2uic/*.1")
           install(FILES ${manpages} DESTINATION share/man/man1)
       endif()
      diff --git a/pylupdate/CMakeLists.txt b/pylupdate/CMakeLists.txt
      index 83e5bf0..a46608c 100644
      --- a/pylupdate/CMakeLists.txt
      +++ b/pylupdate/CMakeLists.txt
      @@ -38,7 +38,7 @@ target_link_libraries(pyside2-lupdate
       install(TARGETS pyside2-lupdate RUNTIME DESTINATION bin)
       
       # Man pages
      -if (NOT win32)
      +if (NOT WIN32)
           file(GLOB manpages "${CMAKE_CURRENT_SOURCE_DIR}/*.1")
           install(FILES ${manpages} DESTINATION share/man/man1)
       endif()
      diff --git a/pyrcc/CMakeLists.txt b/pyrcc/CMakeLists.txt
      index b486e32..2aaf788 100644
      --- a/pyrcc/CMakeLists.txt
      +++ b/pyrcc/CMakeLists.txt
      @@ -12,7 +12,7 @@ target_link_libraries(pyside2-rcc
       install(TARGETS pyside2-rcc RUNTIME DESTINATION bin)
       
       # Man pages
      -if (NOT win32)
      +if (NOT WIN32)
           file(GLOB manpages "${CMAKE_CURRENT_SOURCE_DIR}/*.1")
           install(FILES ${manpages} DESTINATION share/man/man1)
       endif()
      

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            ctismer Christian Tismer
            jschueller Julien Schueller
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes