Details
-
Suggestion
-
Resolution: Done
-
P3: Somewhat important
-
6.2.0, 6.3, 6.4
-
None
-
57c1e8d533 (qt/qtbase/dev) 57c1e8d533 (qt/tqtc-qtbase/dev) 10a2af6611 (qt/qtbase/6.3) 10a2af6611 (qt/tqtc-qtbase/6.3)
Description
With https://codereview.qt-project.org/c/qt/qtbase/+/331201, we can add global defines and disable them for specific targets, which is already quite useful.
However, it would be nice if there was a way to add such global properties only in modules which opt-in into using them: E.g. qtbase and qtdeclarative opt-in, and the property gets set on all targets there, but it does not get set in qtmultimedia, quick3d, etc.
A use-case for this feature would be introducing source breaking changes into a non-leaf module, but hiding the breakage via defines. E.g. https://codereview.qt-project.org/c/qt/qtbase/+/394301 could use it to still provide the removed includes, unless modules claim that they have fixed any breakage.
Attachments
For Gerrit Dashboard: QTBUG-101640 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
400260,1 | build system: support module local definitions | 6.2 | qt/qtbase | Status: NEW | -1 | 0 |
401252,1 | cmake: only use qtbase configuration in qtbase | 6.3 | qt/qtbase | Status: NEW | 0 | 0 |
401253,1 | cmake: only use qtbase configuration in qtbase | 6.2 | qt/qtbase | Status: NEW | -1 | 0 |
400177,4 | build system: support module local definitions | dev | qt/qtbase | Status: MERGED | +2 | 0 |
400259,2 | build system: support module local definitions | 6.3 | qt/qtbase | Status: MERGED | +2 | 0 |
401246,2 | Set QT_SUPERBUILD early | 6.2 | qt/qt5 | Status: MERGED | +2 | 0 |
401247,2 | Set QT_SUPERBUILD early | 6.3 | qt/qt5 | Status: MERGED | +2 | 0 |
401292,2 | Set QT_SUPERBUILD early | dev | qt/qt5 | Status: MERGED | +2 | 0 |
401294,3 | cmake: only use qtbase configuration in qtbase | dev | qt/qtbase | Status: MERGED | +2 | 0 |