Details
-
Task
-
Resolution: Fixed
-
P2: Important
-
None
-
6.2.4, 6.3.0 RC
-
None
Description
By #include ing not only the *.moc, but also the moc_*.cpp files, we can speed up compilation of Qt (albeit not for users of Qt), reduce the TEXT size of libraries, and enable more warnings (like Clang's -Wunused-private-field). By the time we tackle this, there should be a new includemocs6 script (from QTBUG-102886) in QtBase, that no longer requires a qmake build to operate.
- Acceptance criteria: mocs_compilation.cpp files should not #include anything.
- Backport to all branches (6.3, 6.2, 5.15).
- Script incl wrapper: https://codereview.qt-project.org/c/qt/qtbase/+/409553
- inspiration in case stuff goes wrong:
- no QT_END_NAMESPACE found: https://codereview.qt-project.org/c/qt/qtdeclarative/+/409613
- no .cpp found to include the moc-file:
- simple: https://codereview.qt-project.org/c/qt/qtconnectivity/+/409378
- a bit more complicated: https://codereview.qt-project.org/c/qt/qtdeclarative/+/409612
If you have questions, ask mmutz.
Attachments
Issue Links
- is cloned by
-
QTBUG-103287 include moc files [QtQuick3D]
- Closed
For Gerrit Dashboard: QTBUG-103286 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
418126,3 | Qt3DQuick: includemocs | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418127,2 | Qt3DQuickExtras: includemocs | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418128,3 | Qt3DAnimation: includemocs | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418129,2 | Qt3DQuickInput: includemocs | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418130,2 | QtAssimpSceneImportPlugin: includemocs | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418131,2 | QtGLTFSceneImportPlugin: includemocs | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418132,3 | Qt3DLogic: includemocs | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418133,2 | Qt3DRender: includemocs | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418134,2 | QtDefaultGeometryLoaderPlugin: includemocs | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418135,2 | QtGLTFGeometryLoaderPlugin: includemocs | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418162,3 | Qt3DCore: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418163,2 | Qt3DInput: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418165,5 | Qt3DQuick: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418166,3 | Qt3DQuick: includemocs | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418167,2 | Qt3DQuickExtras: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418168,2 | Qt3DQuickExtras: includemocs | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418169,3 | Qt3DAnimation: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418170,3 | Qt3DAnimation: includemocs | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418171,2 | Qt3DQuickInput: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418172,2 | Qt3DQuickInput: includemocs | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418173,2 | QtAssimpSceneImportPlugin: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418174,2 | QtAssimpSceneImportPlugin: includemocs | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418175,2 | QtGLTFSceneImportPlugin: includemocs | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418176,2 | QtGLTFSceneImportPlugin: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418177,3 | Qt3DLogic: includemocs | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418178,3 | Qt3DLogic: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418179,5 | Qt3DRender: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | -1 | 0 |
418180,2 | Qt3DRender: includemocs | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418181,2 | QtDefaultGeometryLoaderPlugin: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418182,2 | QtDefaultGeometryLoaderPlugin: includemocs | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418183,2 | QtGLTFGeometryLoaderPlugin: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418184,2 | QtGLTFGeometryLoaderPlugin: includemocs | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418354,2 | Qtquick3dinputplugin: includemocs | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418355,2 | Fix compile warnings | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418396,2 | Qt3D Tests: includemocs | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418397,3 | Qtquick3dextrasplugin: includemocs | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418398,2 | Qtqtquick3dcoreplugin: includemocs | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418399,3 | Qtquick3danimationplugin: includemocs | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418400,2 | Qtqtquickscene3dplugin: includemocs | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418401,3 | Qt3DQuickRender: includemocs | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418402,2 | Qt3DExtras: includemocs | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418403,2 | Qt3DQuickAnimation: includemocs | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418404,3 | Qt3DQuickScene2D: includemocs | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418405,2 | Qtquick3dlogicplugin: includemocs | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418406,2 | Qtquick3drenderplugin: includemocs | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418413,2 | Qtquick3dinputplugin: includemocs | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418414,2 | Qtquick3dinputplugin: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418415,7 | Fix compile warnings | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418416,3 | Fix compile warnings | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418417,6 | Qt3D Tests: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | -1 | 0 |
418418,3 | Qt3D Tests: includemocs | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418419,3 | Qtquick3dextrasplugin: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418420,3 | Qtquick3dextrasplugin: includemocs | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418421,2 | Qtqtquick3dcoreplugin: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418422,2 | Qtqtquick3dcoreplugin: includemocs | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418423,3 | Qtquick3danimationplugin: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418424,3 | Qtquick3danimationplugin: includemocs | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418425,2 | Qtqtquickscene3dplugin: includemocs | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418426,2 | Qtqtquickscene3dplugin: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418427,3 | Qt3DQuickRender: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418428,3 | Qt3DQuickRender: includemocs | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418429,5 | Qt3DExtras: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418430,2 | Qt3DQuickAnimation: includemocs | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418431,2 | Qt3DQuickAnimation: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418432,2 | Qt3DExtras: includemocs | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418433,2 | Qt3DQuickScene2D: includemocs | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418434,2 | Qt3DQuickScene2D: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418435,2 | Qtquick3dlogicplugin: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418436,2 | Qtquick3dlogicplugin: includemocs | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418437,2 | Qtquick3drenderplugin: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418438,2 | Qtquick3drenderplugin: includemocs | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418442,2 | Qtqtquickscene2dplugin: includemocs | 6.3 | qt/qt3d | Status: MERGED | +2 | 0 |
418444,2 | Qtqtquickscene2dplugin: includemocs | tqtc/lts-5.15 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418445,2 | Qtqtquickscene2dplugin: includemocs | tqtc/lts-6.2 | qt/tqtc-qt3d | Status: MERGED | +2 | 0 |
418856,2 | Qtquick3dinputplugin: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418857,2 | Qtquick3dlogicplugin: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418858,2 | Qtquick3drenderplugin: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418859,2 | Qtquick3danimationplugin: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418860,2 | Qtqtquickscene3dplugin: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418861,2 | Qtquick3dextrasplugin: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418862,2 | Qtqtquick3dcoreplugin: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418863,2 | Qt3DQuickAnimation: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418864,2 | Qt3DQuickScene2D: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418865,2 | Qt3DQuickRender: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418866,3 | Qt3DExtras: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418867,3 | Fix compile warnings | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418868,3 | Qt3D Tests: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418869,3 | Qtqtquickscene2dplugin: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418872,2 | Qt3DQuickExtras: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418873,2 | Qt3DQuick: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418874,2 | Qt3DQuickInput: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418875,2 | Qt3DAnimation: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418876,2 | Qt3DRender: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418877,2 | Qt3DLogic: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418878,2 | QtGLTFGeometryLoaderPlugin: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418879,2 | QtDefaultGeometryLoaderPlugin: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418880,2 | QtGLTFSceneImportPlugin: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418881,2 | QtAssimpSceneImportPlugin: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418882,2 | Qt3DInput: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |
418883,2 | Qt3DCore: includemocs | 6.4 | qt/qt3d | Status: MERGED | +2 | 0 |