Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-104164

Apply [[nodiscard]] to ctors where useful [QtBase]

    XMLWordPrintable

Details

    • 5
    • 16a19a4f4 (dev), 6fc908c00 (dev), df759d34e (6.6), c32576642 (6.6), 123118f82 (dev), ecdd82ac3 (6.6), 603d6351c (dev), 6dba28419 (dev), c823bc2fd (dev), 21c344a22 (dev), ffed43129 (dev), 2a76cf818 (dev), 8cad4c290 (dev), c62e0ed70 (6.6), 308d0b5f9 (6.6)
    • Foundation Sprint 84

    Description

      Depending on the outcome of QTBUG-104161, add either [[nodiscard]] directly, or the wrapper macro to those ctors that QTBUG-104167 defines as targets.

      Attachments

        Issue Links

          is blocked by

          Task - A task that needs to be done. QTBUG-104161 [spike] Find out whether all supported compilers support [[nodiscard]] on ctor, add macro if not

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Task - A task that needs to be done. QTBUG-104167 [spike] Create a policy for [[nodiscard]] on ctors

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          resulted in

          Task - A task that needs to be done. QTBUG-114767 Add Q_NODISCARD_X and Q_NODISCARD_CTOR_X, wrapping [[nodiscard("reason")]]

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          For Gerrit Dashboard: QTBUG-104164
          # Subject Branch Project Status CR V
          484534,2 QSemaphoreReleaser: plaster with [[nodiscard]] dev qt/qtbase Status: MERGED +2 0
          484535,2 QSignalBlocker: plaster with [[nodiscard]] dev qt/qtbase Status: MERGED +2 0
          484536,4 Q(Explicitly)SharedDataPointer: mark ctors [[nodiscard]] dev qt/qtbase Status: MERGED +2 0
          484537,7 Mark all ctors of [[nodiscard]] classes as Q_NODISCARD_CTOR dev qt/qtbase Status: MERGED -1 0
          484624,6 QDebugStateSaver: mark ctors [[nodiscard]] dev qt/qtbase Status: MERGED +2 0
          484625,3 QOrderedMutexLocker: plaster with [[nodiscard]] dev qt/qtbase Status: MERGED +2 0
          484631,2 Q(Read|Write)Locker: unexport the classes dev qt/qtbase Status: ABANDONED +2 0
          484632,6 Q(Read|Write)Locker: mark ctors [[nodiscard]] dev qt/qtbase Status: MERGED +2 0
          484674,5 QMacAutoReleasePool: unexport dev qt/qtbase Status: MERGED +2 0
          484675,4 QMac{,RootLevel}AutoReleasePool: mark ctors [[nodiscard]] dev qt/qtbase Status: MERGED +2 0
          484676,4 QCFString: unexport dev qt/qtbase Status: MERGED +2 0
          484677,4 QAppleRefCounted hierarchy: mark ctors [[nodiscard]] dev qt/qtbase Status: MERGED +2 0
          484709,2 QSignalBlocker: plaster with [[nodiscard]] 6.6 qt/qtbase Status: MERGED +2 0
          484710,2 QSemaphoreReleaser: plaster with [[nodiscard]] 6.6 qt/qtbase Status: MERGED +2 0
          484785,2 QOrderedMutexLocker: plaster with [[nodiscard]] 6.6 qt/qtbase Status: MERGED +2 0
          485639,2 QScoped(Array)Pointer: remove the class-level [[nodiscard]] dev qt/qtbase Status: MERGED +2 0
          486321,2 Q(Read|Write)Locker: mark ctors [[nodiscard]] 6.6 qt/qtbase Status: MERGED +2 0
          486327,2 Mark all ctors of [[nodiscard]] classes as Q_NODISCARD_CTOR 6.6 qt/qtbase Status: MERGED +2 0
          486328,2 Q(Explicitly)SharedDataPointer: mark ctors [[nodiscard]] 6.6 qt/qtbase Status: MERGED +2 0
          486329,2 QScoped(Array)Pointer: remove the class-level [[nodiscard]] 6.6 qt/qtbase Status: MERGED +2 0
          486644,2 QMacAutoReleasePool: unexport 6.6 qt/qtbase Status: MERGED +2 0
          486645,3 QMac{,RootLevel}AutoReleasePool: mark ctors [[nodiscard]] 6.6 qt/qtbase Status: MERGED +2 0
          486646,2 QDebugStateSaver: mark ctors [[nodiscard]] 6.6 qt/qtbase Status: MERGED +2 0
          486704,2 QAppleRefCounted hierarchy: mark ctors [[nodiscard]] 6.6 qt/qtbase Status: MERGED +2 0
          486795,2 QFutureSynchronizer: mark ctors [[nodiscard]] dev qt/qtbase Status: MERGED +2 0
          486923,4 [normative] QUIP-0019: require named ctors to be [[nodiscard]] if ctors should be master meta/quips Status: MERGED +2 0
          486939,2 Div. private RAII/smart ptr classes: mark ctors [[nodiscard]] dev qt/qtbase Status: MERGED +2 0
          486940,2 Q(Shared|Weak|)Pointer: mark ctors [[nodiscard]] dev qt/qtbase Status: MERGED +2 0
          486942,2 QSharedPointer: mark create() [[nodiscard]] dev qt/qtbase Status: MERGED +2 0
          487024,2 QFutureSynchronizer: mark ctors [[nodiscard]] 6.6 qt/qtbase Status: MERGED +2 0
          487066,4 Remove all class-level [[nodiscard]] from the code-base dev qt/qtbase Status: MERGED +2 0
          487094,2 Div. private RAII/smart ptr classes: mark ctors [[nodiscard]] 6.6 qt/qtbase Status: MERGED +2 0
          487110,2 Q(Shared|Weak|)Pointer: mark ctors [[nodiscard]] 6.6 qt/qtbase Status: MERGED +2 0
          487111,2 QSharedPointer: mark create() [[nodiscard]] 6.5 qt/qtbase Status: MERGED +2 0
          487112,3 QSharedPointer: mark create() [[nodiscard]] 6.6 qt/qtbase Status: MERGED +2 0
          487185,4 Mark all remaining RAII/smart pointer class ctors [[nodiscard]] dev qt/qtbase Status: MERGED +2 0
          487357,2 Mark all remaining RAII/smart pointer class ctors [[nodiscard]] 6.6 qt/qtbase Status: MERGED +2 0
          488487,2 Remove all class-level [[nodiscard]] from the code-base 6.6 qt/qtbase Status: MERGED +2 0
          488703,2 QCFString: unexport 6.6 qt/qtbase Status: MERGED +2 0

          Activity

            People

              mmutz Marc Mutz
              mmutz Marc Mutz
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes