Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-105544

qunicodetools.cpp: libthai's th_brk is not thread-safe [2/2]: new API

    XMLWordPrintable

Details

    • 3
    • 19ca03c21 (dev), ed739a5c4 (6.5), 5679f9f82 (dev), 2f96d72f4 (6.5)
    • Foundation Sprint 73

    Description

      The facilities in qunicodetools.cpp are not limited to the GUI thread, so they need to be re-entrant.

      Besides QTBUG-105543 there is another threading issue in qunicodetools' thai support: The th_brk() function is apparently not re-entrant, so https://github.com/tlwg/libthai/pull/1 (available from symbol version 0.1.25) added a new, thread-safe, API where the initialization of global state is explicit (and must be protected by the user with a mutex), but following calls to the th_brk replacement are then thread-safe.

      We should port to the new API. If we don't find it, emit qWarning() and continue to use the old API.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              ievgenii.meshcheriakov Ievgenii Meshcheriakov
              mmutz Marc Mutz
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes