Review toupper/tolower uses [Qt]

The C toupper/tolower functions are locale-dependent. Given the right locale (Türkiye, e.g.):

• tolower(I) is either
  • ı (LATIN SMALL LETTER DOTLESS I; if representable in current charset) or
  • I (unchanged; if it isn't)
• toupper(i) is either
  • İ (LATIN CAPITAL LETTER I WITH DOT ABOVE; if representable) or
  • i (unchanged; if it isn't)

Both results are wrong.

Also, since toupper/tolower are UB unless the argument is 0..255 or EOF, it's UB to even feed a char! You need to cast to uchar first! So, basically all our uses of toupper/tolower are UB!

Please check your respective code bases, book patches, if any, onto this ticket, and, once merged, remove your component from the Jira field.

We have QtMiscUtils::asciiToLower() in QtCore/private/qtools_p.h. It's been backported to 5.15 We don't have asciiToUpper(). You can either port to asciiToLower() or use caseCompareAscii() (which may not be available in Qt 6.2 and 5.15), or wait for asciiToUpper() (from https://codereview.qt-project.org/c/qt/qtbase/+/449457) to make its way through the branches.

It doesn't look like we have uses in public header files. If you find one, then you need to pull the code out-of-line.