Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-111873

qt_attributions.json files should be valid JSON

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P3: Somewhat important
    • None
    • 6.5.0 Beta3
    • Build tools: Other
    • None
    • All
    • 687bbd584 (dev), b0bb1bf33 (6.6), e004cebd1 (6.5), a345c01d6 (dev), c0f13eeb9 (dev), 71ce3b81f (dev), 4319a9ed8 (dev), b30a986ed (6.6), 6fdd7d921 (6.6), 9b57368a7 (6.6), 6dffa72ba (tqtc/lts-6.5), f0c40a2d6 (tqtc/lts-6.5), 874e5be7f (6.6), 80a24bb47 (dev)

    Description

      The qt_attributions.json files are currently invalid JSON, because of entries like this:

          "Copyright": "Copyright (c) 1995-2022 The PNG Reference Library Authors
      Copyright (c) 2000-2022 Cosmin Truta
      ...
      Copyright (c) 1995-1996 Tim Wegner"
      

      The newlines must be replaced by \n or the Copyright field should be allowed to be an array of strings.

      Patch that goes the \n route: https://codereview.qt-project.org/c/qt/qtbase/+/308531

      However, it turns out that this results in quite unreadable, overly long string literals.

      Let's do it like this:

      • change QUIP 007 and state that the Copyright field allows string or string[].
      • change qtattributionsscanner to accept string arrays. The array is joined to a single string with newlines.
      • bulk-change the qt_attribution.json files

      Attachments

        For Gerrit Dashboard: QTBUG-111873
        # Subject Branch Project Status CR V

        Activity

          People

            lugerard Lucie Gerard
            jbornema Joerg Bornemann
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes