Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-114817

Make ~QQmlRefCount() non-virtual

    XMLWordPrintable

Details

    • 8
    • f8c9fd6bf (dev), 3f2183ce2 (dev), 90ddb9ef2 (dev), 4bc2d0377 (6.6)
    • Foundation Sprint 85

    Description

      The presence of a vtable in a class simply supplying a 4-byte ref-count causes the size of the each subclass to grow by 4/12b (32/64-bit). There appears to be no reason for the virtual dtor, in particular as it's already also protected.

      However, any subclass of it may rely on the virtuality of the dtor, so we need to proceed with caution and enlist the compiler's help each step of the way of removing virtualness of dtors down the hierarchy.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            mmutz Marc Mutz
            mmutz Marc Mutz
            Vladimir Minenko Vladimir Minenko
            Alex Blasche Alex Blasche
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes