Details
-
Task
-
Resolution: Fixed
-
P3: Somewhat important
-
None
-
None
-
3
-
5a665bc47 (dev), 4a7c76d4a (dev), 787bb2ad7 (dev), 9194fc5ae (dev), 09169d4ef (dev), 92d4eacaa (dev), 495fd8ccd (dev), 2d6a9ac90 (dev), a90242983 (dev), 5d84fa8e9 (dev), 0740726c9 (dev), cbb51280c (dev), 3923a0f52 (dev), bf3355bd6 (dev), f5c6a5786 (dev)
-
Foundation Sprint 92, Foundation Sprint 93, Foundations Sprint 94
Description
The motivation for this task is to decrease compile time.
At least qevent.h includes qpointer.h, but uses QPointer in-name-only. A forward declaration would suffice.
qpointer.h drags in qsharedpointer.h, which ought to be rather heavy, even though this reporter has no measurements to substantiate that claim.
In QtBase, only qfuture_impl.h also includes qpointer.h, so it seems that removing the qpointer.h include from a central header such as qevent.h might actually help to reduce compile times.
Attachments
For Gerrit Dashboard: QTBUG-117670 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
508475,3 | Include what you need: <QPointer> | dev | qt/qtdeclarative | Status: MERGED | +2 | 0 |
509843,4 | Include what you need: <QPointer> | dev | qt/qtbase | Status: MERGED | +2 | 0 |
511611,2 | Include what you need: <QPointer> | dev | qt/qt3d | Status: MERGED | +2 | 0 |
511613,3 | Include what you need: <QPointer> | dev | qt/qtcoap | Status: MERGED | +2 | 0 |
511614,3 | Include what you need: <QPointer> | dev | qt/qtconnectivity | Status: MERGED | +2 | 0 |
511616,2 | Include what you need: <QPointer> | dev | qt/qtdatavis3d | Status: MERGED | +2 | 0 |
511617,1 | Include what you need: <QPointer> | dev | qt/qtgraphs | Status: ABANDONED | -1 | 0 |
511619,2 | Include what you need: <QPointer> | dev | qt/qtmultimedia | Status: MERGED | +2 | 0 |
511620,2 | Include what you need: <QPointer> | dev | qt/qtnetworkauth | Status: MERGED | +2 | 0 |
511642,2 | Include what you need: <QPointer> | dev | qt/qtpositioning | Status: MERGED | +2 | 0 |
511643,2 | Include what you need: <QPointer> | dev | qt/qtquick3d | Status: MERGED | +2 | 0 |
511645,2 | Include what you need: <QPointer> | dev | qt/qtquickeffectmaker | Status: MERGED | +2 | 0 |
511646,2 | Include what you need: <QPointer> | dev | qt/qtscxml | Status: MERGED | +2 | 0 |
511647,2 | Include what you need: <QPointer> | dev | qt/qtserialbus | Status: MERGED | +2 | 0 |
511651,2 | Include what you need: <QPointer> | dev | qt/qttools | Status: MERGED | +2 | 0 |
511652,2 | Include what you need: <QPointer> | dev | qt/qtvirtualkeyboard | Status: MERGED | +2 | 0 |
511653,2 | Include what you need: <QPointer> | dev | qt/qtwayland | Status: MERGED | +2 | 0 |
511655,2 | Include what you need: <QPointer> | dev | qt/qtwebengine | Status: MERGED | +2 | 0 |
511656,2 | Include what you need: <QPointer> | dev | qt/qtwebview | Status: MERGED | +2 | 0 |