Details
-
Bug
-
Resolution: Fixed
-
P2: Important
-
6.5.5, 6.5, 6.6.3, 6.7.0 Beta2, 6.8.0 FF
-
6.5.3
-
None
-
9d10b7956 (dev), 6c0489e65 (6.7), e5d8daf82 (6.6), 4bc9083a7 (tqtc/lts-6.5)
Description
We have a QML component with a property onlineStatus. Since recently we now get this warning:
[W] (default): "onlineStatus" is not a properly capitalized signal handler name. "onLineStatus" would be correct.
This is obviously wrong. Grepping the sources, it seems to come from this place in qqmlproperty.cpp:
// qqmlproperty.cpp:412 signalName = QQmlSignalNames::badHandlerNameToSignalName(terminal); if (signalName) { qWarning() << terminal << "is not a properly capitalized signal handler name." << QQmlSignalNames::signalNameToHandlerName(*signalName) << "would be correct."; if (findSignal(*signalName)) return; }
I guess the warning should be moved inside the if (findSignal()) block, i.e. only printed when a signal with that name was actually found.
Attachments
For Gerrit Dashboard: QTBUG-118710 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
515555,3 | QQmlProperty: fix signal handler warning | dev | qt/qtdeclarative | Status: MERGED | +2 | 0 |
535939,2 | QQmlProperty: fix signal handler warning | 6.7 | qt/qtdeclarative | Status: MERGED | +2 | 0 |
535988,3 | QQmlProperty: fix signal handler warning | 6.6 | qt/qtdeclarative | Status: MERGED | +2 | 0 |
536653,2 | QQmlProperty: fix signal handler warning | tqtc/lts-6.5 | qt/tqtc-qtdeclarative | Status: MERGED | +2 | 0 |