Loading...

XML

Word

Printable

Details

Type: Technical task
Resolution: Unresolved
Priority: P2: Important
Fix Version/s: None
Component/s: None
Labels:
None

Sprint:
Foundation PM Prioritized
Commits:
c232253fb (dev), a456f4513 (dev), 8be92d0ab (6.7), 043b046d5 (6.7), 120eea95b (dev), 0010b90f8 (dev), 2b2417922 (dev), eec7104cd (dev), 27ab146bc (dev), a61838fcf (dev), a69a58321 (dev), f7e510ad5 (dev), 6efb3db12 (dev), c8ca806f4 (dev), 17a813421 (dev)

Attachments

Gerrit Reviews

- Issue Only
- Show All Reviews
- Show Open Reviews

For Gerrit Dashboard: QTBUG-123625
#	Subject	Branch	Project	Status	CR	V
551468,1	QGrpcCallOptions: declare implicit move and move assign ctors	6.7	qt/qtgrpc	Status: NEW	+2	0
552640,1	QGrpcInterceptorContinuation: suffix underscore	6.7	qt/qtgrpc	Status: NEW	+2	0
558196,5	QGrpcStatus: introduce isOk()	dev	qt/qtgrpc	Status: NEW	-2	0
559226,2	QGrpcStatus: remove initializer for the StatusCode enum	dev	qt/qtgrpc	Status: NEW	-1	0
559662,1	QGrpcClientBase: pass shared_ptr by copy for attachChannel(~)	6.7	qt/qtgrpc	Status: NEW	0	0
560128,14	Move host URI option to QGrpcHttp2Channel	dev	qt/qtgrpc	Status: NEW	0	0

Activity

People

Assignee:: Unassigned

Reporter:: Alexey Edelev

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 22 Mar '24 15:39

Updated:: 26 Mar '24 17:20

Gerrit Reviews

There are 6 open Gerrit changes

QGrpcCallOptions: declare implicit move and move assign ctors

+2 Gerrit Review:
QGrpcInterceptorContinuation: suffix underscore

+2 Gerrit Review:
QGrpcStatus: introduce isOk()

-2 Gerrit Review:
QGrpcStatus: remove initializer for the StatusCode enum

-1 Gerrit Review:
QGrpcClientBase: pass shared_ptr by copy for attachChannel(~)

-1 Gerrit Review:
Move host URI option to QGrpcHttp2Channel

+1 Gerrit Review:

Show There are 67 closed Gerrit changes

Hide There are 67 closed Gerrit changes

qtgrpc: unify includes to the schema <Module/file.h>: Gerrit Review:

qtgrpc: unify includes to the schema <Module/file.h>: Gerrit Review:

qtgrpcquick: unify includes to the schema <Module/file.h>: Gerrit Review:

qtgrpcquick: unify includes to the schema <Module/file.h>: Gerrit Review:

QAbstractGrpcChannel: modernize api with [[nodiscard]]: Gerrit Review:

QAbstractGrpcChannel: mark single argument ctor as explicit: Gerrit Review:

QAbstractGrpcChannel: make dtor public and virtual: Gerrit Review:

QAbstractGrpcChannel: declare implicit move and move assign ctors: Gerrit Review:

QAbstractGrpcClient: make protected dtor public: Gerrit Review:

QGrpcCallOptions: modernize api with [[nodiscard]]: Gerrit Review:

QGrpcCallOptions: declare implicit move and move assign ctors: Gerrit Review:

QGrpcCallReply: include missing headers: Gerrit Review:

QGrpcChannelOperation: include missing headers: Gerrit Review:

QGrpcChannelOperation: declare public destructor: Gerrit Review:

QGrpcChannelOperation: modernize api with [[nodiscard]]: Gerrit Review:

QGrpcChannelOperation: transform const ref QBA signals into QBASV: Gerrit Review:

QGrpcChannelOptions: declare move and move assign ctors: Gerrit Review:

QGrpcChannelOptions: modernize api with [[nodiscard]]: Gerrit Review:

QAbstractGrpcChannel: modernize api with [[nodiscard]]: Gerrit Review:

QAbstractGrpcChannel: mark single argument ctor as explicit: Gerrit Review:

QGrpcCallReply: include missing headers: Gerrit Review:

QAbstractGrpcChannel: make dtor public and virtual: Gerrit Review:

QGrpcChannelOperation: include missing headers: Gerrit Review:

QAbstractGrpcChannel: declare implicit move and move assign ctors: Gerrit Review:

QGrpcChannelOperation: declare public destructor: Gerrit Review:

QAbstractGrpcClient: make protected dtor public: Gerrit Review:

QGrpcChannelOperation: modernize api with [[nodiscard]]: Gerrit Review:

QGrpcCallOptions: modernize api with [[nodiscard]]: Gerrit Review:

QGrpcInterceptorContinuation: suffix underscore: Gerrit Review:

QGrpcClientInterceptor: follow the rule of five: Gerrit Review:

QGrpcOperation: make protected dtor public: Gerrit Review:

QGrpcOperation: modernize api with [[nodiscard]]: Gerrit Review:

QGrpcSerializationFormat: return a view for suffix(): Gerrit Review:

QGrpcSerializationFormat: modernize api with [[nodiscard]]: Gerrit Review:

QGrpcSerializationFormat: include missing <QtCore/qbytearrayview.h>: Gerrit Review:

QGrpcStatus: modernize api with [[nodiscard]]: Gerrit Review:

qgrpcstream: explicitly delete copy and move ctors: Gerrit Review:

Add the missing condition to the startStream type trait check: Gerrit Review:

Make QGrpcCallOptions required for all internal QAbstractGrpcChannel calls: Gerrit Review:

Fix the QAbstractGrpcClient::channel signature: Gerrit Review:

Use Q_UNREACHABLE_RETURN in QAbstractGrpcClient::startStream: Gerrit Review:

Remove QAbstractGrpcClient::serializer method: Gerrit Review:

Export only out-of-line members of the non-polymorphic QGrpcCallOptions: Gerrit Review:

Return const ref to QGrpcMetadata in QGrpcOperation::metadata: Gerrit Review:

Prettify QGrpcCallReply::subscribe method: Gerrit Review:

Remove the redundand definition of the QGrpcCallReply default ctor: Gerrit Review:

Fix the QGrpcChannelOperation::setOptions method: Gerrit Review:

Avoid exporting final template QGrpcInterceptorContinuation: Gerrit Review:

Split the QGrpcStatus constructor: Gerrit Review:

QGrpcChannelOptions: declare move and move assign ctors: Gerrit Review:

QGrpcOperation: make protected dtor public: Gerrit Review:

QGrpcChannelOptions: modernize api with [[nodiscard]]: Gerrit Review:

QGrpcOperation: modernize api with [[nodiscard]]: Gerrit Review:

QGrpcSerializationFormat: modernize api with [[nodiscard]]: Gerrit Review:

QGrpcSerializationFormat: include missing <QtCore/qbytearrayview.h>: Gerrit Review:

QGrpcStatus: modernize api with [[nodiscard]]: Gerrit Review:

qgrpcstream: explicitly delete copy and move ctors: Gerrit Review:

QGrpcSerializationFormat: mark single arg ctor as explicit: Gerrit Review:

Add the missing condition to the startStream type trait check: Gerrit Review:

QGrpcSerializationFormat: mark single arg ctor as explicit: Gerrit Review:

Add the 'writesDone' methods to client-side streaming operations: Gerrit Review:

Make QGrpcClientBase::trySerialize const: Gerrit Review:

QGrpcStatus: use comparison helper macros: Gerrit Review:

QGrpcStatus: convert to THIN value type à la quip22: Gerrit Review:

QGrpcClientBase: pass shared_ptr by copy for attachChannel(~): Gerrit Review:

QGrpcClientBase: apply clang-format: Gerrit Review:

Remove the 'stream' prefix from all streaming methods: Gerrit Review: