Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-17278

Typo in zlib.h patch

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: P3: Somewhat important P3: Somewhat important
    • 4.8.0
    • 4.7.1
    • None
    • Should influence all I noticed it under Windows 7 when I tried to use the gzungetc function directly and the linker could not find it.
    • 64c22524372450f37ae2c11c3f62a82ad18784e9

      Hello I have found a typo in the zlib.h header when it is patched for Qt. Version 4.7.1.

      File src/3rdparty/zlib/zlib.h.

      Note:
      ZEXTERN int ZEXPORT gzungetc OF((int c, gzFile file));

      Should be

      ZEXTERN int Q_ZEXPORT gzungetc OF((int c, gzFile file));

      see below:

      ZEXTERN int Q_ZEXPORT gzgetc OF((gzFile file));
      /* Reads one byte from the compressed file. gzgetc returns this byte or -1 in case of end of file or error.
      */

      ZEXTERN int ZEXPORT gzungetc OF((int c, gzFile file));
      /* Push one character back onto the stream to be read again later. Only one character of push-back is allowed. gzungetc() returns the character pushed, or -1 on failure. gzungetc() will fail if a character has been pushed but not read yet, or if c is -1. The pushed character will be discarded if the stream is repositioned with gzseek() or gzrewind().
      */

      ZEXTERN int Q_ZEXPORT gzflush OF((gzFile file, int flush));

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            vgt Eirik Aavitsland
            cafun Jeff Franklin
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes