Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-18870

qmake's UNIX Makefile generator causes "make install" errors be ignored.

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P2: Important
    • 5.14.0 Alpha
    • 4.7.2, 5.12.0 Beta 2
    • Build tools: qmake
    • None
    • 20e9422e069a27b7e29b54207447e6ca02b3a55a (qt/qtbase/dev)

    Description

      See this rule, for example:
      install_target: first FORCE
      @$(CHK_DIR_EXISTS) $(INSTALL_ROOT)/usr/bin/ || $(MKDIR) $(INSTALL_ROOT)/usr/bin/
      -$(INSTALL_PROGRAM) "$(QMAKE_TARGET)" "$(INSTALL_ROOT)/usr/bin/$(QMAKE_TARGET)"

      Due to the leading dash on the command, "make" ignores any errors and returns 0, so scripts or other tools caling "make install" cannot know that it failed, even though it seems rather obvious that they should.

      Attachments

        Issue Links

          resulted in

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-71000 qmake: install_gen_headers error got ignored

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          For Gerrit Dashboard: QTBUG-18870
          # Subject Branch Project Status CR V
          262607,5 Do not ignore exit codes of install commands dev qt/qtbase Status: MERGED +2 0
          266118,12 Do not ignore exit codes when installing meta files dev qt/qtbase Status: MERGED +2 0

          Activity

            People

              jbornema Joerg Bornemann
              kandeler Christian Kandeler
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes