Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-22310

Inappropriate use of QSKIP in QMdiSubwindow autotest

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P3: Somewhat important
    • None
    • 5.0.0
    • None
    • aeb21c73c5e4fc585340145374800a5e285e7ab7

    Description

      In qtbase/tests/auto/widgets/widgets/qmdisubwindow/tst_qmdisubwindow.cpp, several test functions are effectively disabled with:

      QSKIP("Until we have a QEvent::WindowFlagsChange event, this will skip");
      

      These QSKIPs would be better written as QEXPECT_FAIL, so that if the feature appears the test will report that it needs to be updated. Regardless of whether this is a QSKIP or a QEXPECT_FAIL, the message must refer to a bug report that requests the needed feature.

      Attachments

        For Gerrit Dashboard: QTBUG-22310
        # Subject Branch Project Status CR V

        Activity

          People

            seahumad [BB] Sergio Ahumada (Inactive)
            jasmcdon Jason McDonald (Closed Nokia Identity. Please assign to "macadder" instead) (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes