Details
-
Bug
-
Resolution: Done
-
P3: Somewhat important
-
5.0.0
-
None
-
e3d334e7c3a74bc3379b4f673ca1d90bee28f9d2.
Description
In qtbase/tests/auto/corelib/tools/qvector/tst_qvector.cpp, the outOfMemory() test function is disabled with:
QSKIP("This test crashes on many of our machines.");
If the test function is not useful, it should be removed.
If this skip was added due to a known bug, it would be better to use QEXPECT_FAIL() here, so that when the bug is fixed the test clearly reports that it needs to be updated. (If this remains a QSKIP, there is no warning that the test is out-of-date and the bug could reappear without anybody being informed.) The QEXPECT_FAIL should refer to an appropriate bug report documenting the known bug.
If the skip was added to avoid a piece of code that crashes, the text of the skip message must be updated to refer to an appropriate bug report.