Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-22424

Inappropriate use of #if 0 in QStaticText autotest

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4: Low P4: Low
    • 6.7.0 FF
    • 5.0.0
    • GUI: Text handling
    • None
    • 297f1da1a (dev)

      In tests/auto/gui/text/qstatictext/tst_qstatictext.cpp, the rotatedScaledAndTranslatedPainter() test function is disabled with #if 0.

      In general, it would be better to use QEXPECT_FAIL to handle this, as the test would still be compile-tested and the developer would be informed if the bug was fixed by someone else. If QEXPECT_FAIL cannot be used (because the test crashes or is unstable), QSKIP is still preferable to #if 0.

      Whether QEXPECT_FAIL or QSKIP is used, the xfail/skip message should reference a bug report describing the problem that caused the test to be disabled.

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            sletta Gunnar Sletta
            jasmcdon Jason McDonald (Closed Nokia Identity. Please assign to "macadder" instead) (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes