Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-31439

null pointer access in QQuickVisualDataModelPrivate::incubatorStatusChanged

    XMLWordPrintable

Details

    • e4fc75edaedead3092aace3a29a0aafdd0e86a77

    Description

      I found an unguarded pointer access in QQuickVisualDataModelPrivate::incubatorStatusChanged:

      diff --git a/src/quick/items/qquickvisualdatamodel.cpp b/src/quick/items/qquickvisualdatamodel.cpp
      index a297ec9..9de7922 100644
      — a/src/quick/items/qquickvisualdatamodel.cpp
      +++ b/src/quick/items/qquickvisualdatamodel.cpp
      @@ -817,7 +817,9 @@ void QQuickVisualDataModelPrivate::incubatorStatusChanged(QVDMIncubationTask *in
      delete cacheItem->object;
      cacheItem->object = 0;
      cacheItem->scriptRef -= 1;

      • cacheItem->contextData->destroy();
        + if (cacheItem->contextData != 0)
        + cacheItem->contextData->destroy();
        cacheItem->contextData = 0;
        if (!cacheItem->isReferenced()) {
        removeCacheItem(cacheItem);

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            florian.haenel Florian Hänel
            florian.haenel Florian Hänel
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes