Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-33206

webkit-qtwebkit-23/Source/WebCore/platform/graphics/Font.cpp:619: possible bad if test ?

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P2: Important
    • None
    • 4.8.5
    • WebKit
    • None
    • fedora Linux.

    Description

      I just ran the static analyser "cppcheck" over the source
      code of qtwebkit-2.3.2

      It said

      [/home/dcb/rpmbuild/BUILD/webkit-qtwebkit-23/Source/WebCore/platform/graphics/Font.cpp:619]: (warning) Logical conjunction always evaluates to false: c <= 8047 && c >= 127488.

      Source code is

      // Emoji.
      if (c >= 0x1F200 && c <= 0x1F6F)
      return true;

      I agree with the analyser. Suggest code rework.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            allan.jensen Allan Sandfeld Jensen
            dcb David Binderman
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes