Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-33970

installed cmake file require source include directories

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Not Evaluated
    • 5.2.0 Beta1
    • 5.2.0 Alpha
    • Build System
    • None
    • Debian 6, GCC 4.8
    • 786b278f91aa4d5f1ff8fa10555bf6c8741c96a0

    Description

      In my <installed Qt prefix>/lib/cmake/Qt5Core/Qt5CoreConfig.cmake, there is the following:

      <snip>
          set(_Qt5Core_OWN_INCLUDE_DIRS "${_qt5Core_install_prefix}/include/" "${_qt5Core_install_prefix}/include/QtCore")
          set(Qt5Core_PRIVATE_INCLUDE_DIRS)
          list(APPEND _Qt5Core_OWN_INCLUDE_DIRS
              /home/ian/atlassian/qt-everywhere-enterprise-src-5.2.0-alpha/qtbase/include /home/ian/atlassian/qt-everywhere-enterprise-src-5.2.0-alpha/qtbase/include/QtCore
          )
          set(Qt5Core_PRIVATE_INCLUDE_DIRS
              /home/ian/atlassian/qt-everywhere-enterprise-src-5.2.0-alpha/qtbase/include/QtCore/5.2.0 /home/ian/atlassian/qt-everywhere-enterprise-src-5.2.0-alpha/qtbase/include/QtCore/5.2.0/$
          )
      
          foreach(_dir ${_Qt5Core_OWN_INCLUDE_DIRS})
              _qt5_Core_check_file_exists(${_dir})
          endforeach()
      <snip>
      

      Where "/home/ian/atlassian/qt-everywhere-enterprise-src-5.2.0-alpha" is the directory I built Qt in. There is no apparent reason for these list(APPEND)'s. And due to the _qt5_Core_check_file_exists macro, this results in a CMake error when trying to cmake configure anything without the source directory present.

      Doing a git blame I see this was done in I555064cd92691459222463df9917f8222e31323b to solve QTBUG-33145

      So I guess the question is why is CMAKE_ADD_SOURCE_INCLUDE_DIRS enabled?

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            stephen.kelly Stephen Kelly (Unused account) (Inactive)
            ian.monroe Ian Monroe
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes