Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-35479

qtxmlpatterns-opensource-src-5.2.0-rc1/src/xmlpatterns/data/qdaytimeduration.cpp: 2 * bad if test ?

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P3: Somewhat important
    • 5.3.0
    • 5.2.0 RC1
    • XML: QtXmlPatterns
    • None
    • 494882adadb33ffb7a7a9b2fa9356362df87d3bf

    Description

      Static analyser cppcheck just said

      1.

      [data/qdaytimeduration.cpp:170] -> [data/qdaytimeduration.cpp:170]: (style) Same expression on both sides of '||'.

      Source code is

      if(m_seconds || m_seconds)

      maybe

      if(m_seconds || m_mseconds)

      was intended.

      2.

      [data/qdaytimeduration.cpp:148] -> [data/qdaytimeduration.cpp:148]: (style) Same expression on both sides of '&&'.

      if(!m_hours && !m_minutes && !m_seconds && !m_seconds)

      Duplicate.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            jbornema Joerg Bornemann
            dcb David Binderman
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes