Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-41453

Wrong valgrind version check

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P3: Somewhat important
    • 5.4.0 RC
    • 5.4.0 Alpha
    • Testing: qtestlib
    • None
    • 7095cdabc9e5465a33adb9d68782b4541853d964 (5.4, 16.10.2014, 5.4)

    Description

      The version check in QBenchmarkValgrindUtils::haveValgrind() fails for Valgrind version like 3.10.5 because of a wrong regular expression:

      QRegExp rx(QLatin1String("^valgrind-([0-9]).([0-9]).[0-9]"));
      

      It should be:

      QRegExp rx(QLatin1String("^valgrind-([0-9]+).([0-9]+).[0-9]"));
      

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            kleint Friedemann Kleint
            hardcorevirus Oliver Becker
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes