Description
WebEngine's demobrowser uses QNAM for downloading icons propagated by the iconUrlChanged signal. QNAM can't download icons when visiting authenticated pages since the credentials are handled by Chromium. Use Chromium's WebContents::DownloadImage() instead and provide API to use it indirectly via the WebEngine API.
The problem is the same for the Quick API. The Quick Image item doesn't support the authentication and can't download the icon in this case. Provide the icon downloaded by WebContents::DownloadImage() via the Quick API somehow (new quick item for icons, imageprovider, etc)
Moreover, WebEngine's API for icons (favicon manager) should be able to provide the best quality of icons if set. This could be configured via WebEngine Settings (icon download modes).
The QtWebKit's Widget API has a QIcon icon() method that returns the icon for the current page. This API should be added to WebEngine Widgets too.
Attachments
For Gerrit Dashboard: QTBUG-51179 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
150667,6 | Clean up FaviconManager and fix icon url in NavigationEntry | 5.7 | qt/qtwebengine | Status: MERGED | +2 | 0 |
150668,4 | Fix iconChanged signal in Quick API | 5.7 | qt/qtwebengine | Status: MERGED | +2 | 0 |
151057,9 | Add settings for FaviconManager's icon download modes | 5.7 | qt/qtwebengine | Status: MERGED | +2 | 0 |
151314,7 | Add multi-sized favicon test | 5.7 | qt/qtwebengine | Status: MERGED | +2 | 0 |
151315,11 | Add icon property and iconChanged signal to QWebEnginePage | 5.7 | qt/qtwebengine | Status: MERGED | +2 | 0 |
154018,7 | Add QQuickWebEngineFaviconProvider | 5.7 | qt/qtwebengine | Status: MERGED | -2 | 0 |
155531,1 | Add iconUrl property and iconUrlChanged signal to WebEngineView | 5.7 | qt/qtwebengine | Status: ABANDONED | +1 | 0 |
155559,12 | Combine candidate icons for a page into a single icon | 5.7 | qt/qtwebengine | Status: MERGED | -2 | 0 |
157142,4 | Add missing icon getter and corresponding signal to QWebEngineView | 5.7 | qt/qtwebengine | Status: MERGED | +2 | 0 |