Details
Description
The new context menu action to save the page should be made optional, and opt in.
E.g. the two qt quick browser examples do not handle it directly:
For webengine/minimal, activating 'Save' from the context menu does nothing. The second try leads to an assert:
ASSERT: "!m_ongoingDownloads.contains(info.id)" in file /home/kakoehne/dev/qt/5.7/src/qtwebengine/src/webengine/api/qquickwebengineprofile.cpp, line 174
Aborted (core dumped)
For webengine/nanobrowser a GUI is shown which seems however also disfunctional. E.g. the file is always saved in .mhtml format.
It seems the action does require some handling in the app to be functional, and therefore should be opt-in. The same goes for the widget's action.
Attachments
For Gerrit Dashboard: QTBUG-52370 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
154891,2 | Fix handling of unaccepted downloads in QtQuick API | 5.6 | qt/qtwebengine | Status: ABANDONED | 0 | 0 |
154899,2 | Fix handling of unaccepted downloads in QtQuick API | 5.7 | qt/qtwebengine | Status: MERGED | +2 | 0 |
155412,3 | Remove "Save Page" web action from the standard context menu | 5.7 | qt/qtwebengine | Status: MERGED | +2 | 0 |