Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-56092

Reconsider API for WebEngineVIew::[can]ViewSource

    XMLWordPrintable

Details

    • Task
    • Resolution: Done
    • P1: Critical
    • 5.8.0
    • 5.8.0 Alpha
    • WebEngine
    • None
    • 2ec47c9921a1e381943159f540b45c105d2ff1db

    Description

      From API review discussion (see also https://codereview.qt-project.org/#/c/170500/2/src/webengine/api/qquickwebengineview_p.h):

      • Shouldn't WebEngineView::viewSource() rather be a WebAction? That's at least how most (all?) context menu actions are implemented.
      • If we make it a WebAction, shall we rather have a generic 'webActionEnabled' function, instead of WebEngineView::canViewSource()?

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            pvarga Peter Varga
            kkohne Kai Köhne
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes