Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-58425

Hard-coded constant "16" instead of "CustomColorCount" in qcolordialog.cpp

    XMLWordPrintable

Details

    • All
    • 8637235e855ef9ad88aa56404a1d16387610e227 (qt/qtbase/5.12)

    Description

      The line "nextCust = (nextCust+1) % 16;" in the following code snippet uses "16" instead of "QColorDialogStaticData::CustomColorCount" (which is unfortunately not defined in an accessible header file).

      void QColorDialogPrivate::_q_addCustom()
      {
          QColorDialogOptions::setCustomColor(nextCust, cs->currentColor());
          if (custom)
              custom->update();
          nextCust = (nextCust+1) % 16;
      }
      

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            chehrlic Christian Ehrlicher
            wschenke Winfried Schenke
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes