Random crash in (BOOL)validateMenuItem:(NSMenuItem*)menuItem

Sometimes the application crashes in qcocoamenu.mm

- (BOOL)validateMenuItem:(NSMenuItem*)menuItem

I debugged it by adding a bunch of logging to the validateMenuItem, the places where the NSMenuItem is released and to the constructor and destructor of QCocoaMenuItem and noticed that when it crashes the QCocoaMenuItem it tries to use in validateMenuItem is already destroyed.

The NSMenuItem can be released in multiple different places and none of them update the tag of it. Calling release for the item doesn't necessarily cause it to be deallocated since it only reduces the reference count of it and thus the tag will still point to the QCocoaMenuItem and when that QCocoaMenuItem gets destroyed the NSMenuItem will point to already released memory.