Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-68580

Raycasting broken due to missing job dependency

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P1: Critical
    • 5.11.1
    • 5.11.0
    • Qt3D
    • None
    • 6abed231ae3677e25406d63cc1ad279614acdf3d

    Description

      Raycasting is unstable for many scenes, not reporting hits when it should. This seems to boil down to a missing job dependency:

      diff --git a/src/render/renderers/opengl/renderer/renderer.cpp b/src/render/renderers/opengl/renderer/renderer.cpp
      index b889799a3..5f2505083 100644
      --- a/src/render/renderers/opengl/renderer/renderer.cpp
      +++ b/src/render/renderers/opengl/renderer/renderer.cpp
      @@ -214,6 +214,7 @@ Renderer::Renderer(QRenderAspect::RenderType type)
           m_expandBoundingVolumeJob->addDependency(m_updateWorldBoundingVolumeJob);
           m_updateShaderDataTransformJob->addDependency(m_worldTransformJob);
           m_pickBoundingVolumeJob->addDependency(m_expandBoundingVolumeJob);
      +    m_rayCastingJob->addDependency(m_expandBoundingVolumeJob);
           // m_calculateBoundingVolumeJob's dependency on m_updateTreeEnabledJob is set in renderBinJobs
      
           // Dirty texture gathering depends on m_syncTextureLoadingJob
      

      Attachments

        Issue Links

          For Gerrit Dashboard: QTBUG-68580
          # Subject Branch Project Status CR V

          Activity

            People

              lagocs Laszlo Agocs
              lagocs Laszlo Agocs
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes