Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-71208

QPicture crashes on malformed picture

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P1: Critical
    • 5.11.3, 5.12.0 RC
    • 5.12.0 Beta 2
    • GUI: Painting
    • None

    Description

      A malformed picture causes qChecksum() to SIGSEGV. The cause of the
      segmentation fault is a buffer over-read. This happens when the picture is
      first loaded and then the format of the picture is checked using
      QPicturePrivate::checkFormat() function. This function uses qChecksum()
      function to calculate the checksum of the picture and compare if the returned
      CRC-16 checksum is valid. However the malformed picture causes a crash in a
      qChecksum() function before the actual checksum validation is made.

      The attachment contain everything needed to reproduce.

      Attachments

        1. crash.pic
          0.0 kB
        2. qpicture-crash.cpp
          0.3 kB
        For Gerrit Dashboard: QTBUG-71208
        # Subject Branch Project Status CR V

        Activity

          People

            vgt Eirik Aavitsland
            markosilokunnas Erkki Esimerkki
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes