Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-73893

QV4::PropertyKey is a bit of a mess

    XMLWordPrintable

Details

    • 68b7a66a6e4d673d11aab44cb87b3f005cdff8ea (qt/qtdeclarative/dev)

    Description

      PropertyKey is a limited version of QV4::Value. We should privately inherit from Value and only expose the limited set of methods we need. Also, there is a hole at UINT_MAX, which is a bit of a mess. In many cases, we use it in this way:

          uint index = foo.asArrayIndex();
          if (index < UINT_MAX) .....
      

      It'd be just as readable to do a isArrayIndex first, and then get the index (which might even do an assert on isArrayIndex).

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            ulherman Ulf Hermann
            erikv Erik Verbruggen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes