Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-74373

QWaylandWindow should not inherit from the wl_surface wrapper

    XMLWordPrintable

Details

    • Task
    • Resolution: Done
    • P2: Important
    • 5.14.0 Alpha
    • None
    • QPA: Wayland
    • None
    • Linux/Wayland

    Description

      In the beginning, there was a direct mapping between a QWaylandWindow and a wl_surface.

      With xdg_shell (and other shell) this is not the case anymore. Changing certain properties of a QWindow requires creating a new wl_surface (because it changes role). This is problematic because some parts of the platform plugin relies on this assumption to identify if the wl_surface has changed.

      We should therefore use composition rather than inheritance. I.e. a QWaylandWindow may have a wl_surface.

      Furthermore, ownership may not even be direct, i.e. the QWaylandWindow may have an xdg_surface which has a wl_surface.

      This would also hopefully let us reuse the new wl_surface class for things that are not a QPlatformWindow, but still require a wl_surface, such as the cursor surface, or parts of window decorations.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            johanhelsing Johan Helsing
            johanhelsing Johan Helsing
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes