Details
-
Bug
-
Resolution: Done
-
P1: Critical
-
None
-
5.14
-
None
-
6c787542df32c59fe0299b2ad884968de28dbcba 291b95d201dc204db5f1a44cd2a03b30f116b032
Description
https://codereview.qt-project.org/#/c/254879/ in qtquickcontrols2.git requires https://codereview.qt-project.org/#/c/254888/ in qtdeclarative.git. https://codereview.qt-project.org/#/c/254888/ has to be merged first, but in doing so it broke the build:
qquickcombobox.cpp:187:13: error: ‘QString QQuickComboBoxDelegateModel::stringValue(int, const QString&)’ marked ‘override’, but does not override
We need to remove the override so it compiles, then temporarily skip any failing ComboBox tests that result from the function not being called.
Attachments
For Gerrit Dashboard: QTBUG-74919 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
257976,2 | Fix broken build | dev | qt/qtquickcontrols2 | Status: MERGED | +2 | 0 |
259461,2 | tst_combobox.qml: remove temporary skips | dev | qt/qtquickcontrols2 | Status: MERGED | +2 | 0 |