Details
-
User Story
-
Resolution: Done
-
P1: Critical
-
None
-
None
Description
Currently QtSvg needs to set a CMAKE_MODULE_PATH to include QtSetup, QtPostProcess and FeatureSummary in the top level CMakeLists.txt file, as well as BUILD_SHARED_LIBS option, and other small things.
We should encapsulate these into XXbegin and XXend macros which would be defined when doing find_package(Qt5Core), which would result in less duplicate code in qtsvg, declarative, etc.
Attachments
For Gerrit Dashboard: QTBUG-75580 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
261758,3 | Use the new macros introduced in qtbase for building qtsvg | wip/cmake | qt/qtsvg | Status: MERGED | +2 | 0 |
261759,4 | Encapsulate commands for building other repos into two macros | wip/cmake | qt/qtbase | Status: MERGED | +2 | 0 |
261802,4 | Use the qt_build_repo() macros for building qtbase as well | wip/cmake | qt/qtbase | Status: MERGED | +2 | 0 |
261836,3 | Use the new BuildInternals package | wip/cmake | qt/qtsvg | Status: MERGED | +2 | 0 |